Skip to content

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Oct 1, 2025

Describe your changes

Closes #3901 .
Closes #3883.

Reworks the sdk to address the followings:

  • Takes the tx arguments relative to wrapping into an optional separate type (to better control whether a tx should be wrapped or not during the build phase)
  • Improves the dump and dry-run args by making the enum (inner or wrapper)
  • Removes the wrapper signing data from SigningTxData and move it to a new SigningWrapperData which contains all the signing data for a batch
  • Simplified the interface of aux_signing_data
  • The tx builders will now return a separate signing data variant based on wether the tx was wrapped or not
  • Simplified the logic when handling the signatures of a dumped transaction
  • Some new safety checks on operations, like avoiding casting a wrapper tx to a raw one or submitting a non-wrapped transaction
  • Removes some useless dispatcher functions
  • Removes explicit handling of the MASP address as a tx owner. The owner should not be specified in these cases
  • Minor changes to the interface of the build_batch function
  • Removed the owner for reveal_pk (no signature is needed for this transaction)

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

This is an automatic backport of pull request #4816 done by [Mergify](https://mergify.com).

grarco and others added 27 commits October 1, 2025 17:09
(cherry picked from commit 167a642)
(cherry picked from commit a0f462f)
(cherry picked from commit 20991d2)
(cherry picked from commit 7106c1f)
(cherry picked from commit 9e76505)
(cherry picked from commit 8111e2d)
(cherry picked from commit 73c9efd)
(cherry picked from commit 603b826)
(cherry picked from commit 3394fd7)
@mergify
Copy link
Contributor Author

mergify bot commented Oct 1, 2025

🧪 CI Insights

Here's what we observed from your CI run for 445bad6.

🟢 All jobs passed!

But CI Insights is watching 👀

@tzemanovic tzemanovic added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Oct 1, 2025
@codecov
Copy link

codecov bot commented Oct 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@mergify mergify bot added the queued label Oct 1, 2025
mergify bot added a commit that referenced this pull request Oct 1, 2025
@mergify mergify bot merged commit 7f27de7 into maint-201.0 Oct 1, 2025
23 of 24 checks passed
@mergify mergify bot deleted the mergify/bp/maint-201.0/pr-4816 branch October 1, 2025 18:48
@mergify mergify bot removed the queued label Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants